fix(rust): wasm-pack arguments + fix libs/apps relative paths #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the PR! I haven't actually finished the wasm support for the plugin, but I'm happy you're testing it out 😄 I'll take a look as soon as I can. |
|
Thank you for checking this. For more context: It kinda works for me, the target does build the wasm and all and I can pick it up in my ts app through alias, although the implementation is very basic indeed i.e. I need to rebuild the wasm on every change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two issues that are interconnected in code
wasm-pack doesn't recognize
-pproperty and expects passing the project root without-pthe plugin code doesn't respect libs/apps folders and only uses the app name, not prefixing it, therefore it doesn't recognize if i.e. my libs dir = packages/, and my app is
my-lib, it'll search in./my-libinstead of./packages/my-lib